Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Office2016 support #586

merged 48 commits into from Apr 2, 2019


None yet
3 participants
Copy link

twsouthwick commented Apr 1, 2019

No description provided.

twsouthwick added some commits Dec 20, 2017

Merge pull request #394 from twsouthwick/update-office2016
Update office2016 from master
Remove version checking to get schema data
There were previously checks at multiple levels to get the schema level.
This change passes the FileFormatVersions object all the way through so
that the decision is done on whether there is a resource or not. In the
future, this will allow new versions with minimal code churn.
Merge pull request #455 from twsouthwick/update-2016
* Compact generated schema code (#450)

* Change format version to indicate lowest supported version for schemas (#452)

* Streamline initialization in OpenXmlPartReader (#454)

* Add tests for XmlConvertingReader and simplify code (#453)
Merge pull request #499 from OfficeDev/master
Merge master into feature/office2016

twsouthwick and others added some commits Nov 2, 2018

Merge pull request #526 from twsouthwick/merge-from-master
Merge from master into Office2016

This comment has been minimized.

Copy link
Collaborator Author

twsouthwick commented Apr 1, 2019


FYI the number changes in O*UnionHelper.g.cs, *.constraints, and *.restraints.xml are due to order differences by inserting properties in. They are calculated during the schema generation and can be considered "magic" numbers. Long term, we can hopefully remove them (I've some progress in removing dependency on them), but for now, it's still needed.

@tomjebo tomjebo merged commit ae79a43 into OfficeDev:master Apr 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.