Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RootPart property to OpenXmlPackage #661

Merged
merged 6 commits into from Jan 10, 2020

Conversation

@twsouthwick
Copy link
Collaborator

twsouthwick commented Dec 20, 2019

Some code will manually do a switch against the document type and requires a knowledge of what types are which; this exposes a simple way to access this information from an OpenXmlPackage.

@twsouthwick

This comment has been minimized.

Copy link
Collaborator Author

twsouthwick commented Dec 20, 2019

@tomjebo @ThomasBarnekow Can you take a look at this? I'm not certain about the name, or if it would be useful to have public. Thoughts?

twsouthwick added 3 commits Dec 20, 2019
@ThomasBarnekow

This comment has been minimized.

Copy link
Contributor

ThomasBarnekow commented Dec 22, 2019

@twsouthwick and @tomjebo, I like this idea.

RootPart works well for me because it corresponds to the RootElement property of the OpenXmlPart in terms of naming, function, and visibility. Therefore, I would also make it public.

twsouthwick added 2 commits Jan 2, 2020
@twsouthwick twsouthwick merged commit ffa7596 into OfficeDev:master Jan 10, 2020
3 checks passed
3 checks passed
OfficeDev.Open-XML-SDK #2.10.0-root-part.43 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.