Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing values to `CompatSettingNameValues` #706

Merged

Conversation

@twsouthwick
Copy link
Collaborator

twsouthwick commented Mar 23, 2020

Fixes #451

@twsouthwick

This comment has been minimized.

Copy link
Collaborator Author

twsouthwick commented Mar 23, 2020

@twsouthwick twsouthwick force-pushed the twsouthwick:useWord2013TrackBottomHyphenation branch from 6279647 to 495be4c Mar 23, 2020
Copy link
Collaborator

tomjebo left a comment

we're also missing this one: allowHyphenationAtTrackBottom. useWord2013TrackBottomHyphenation is related for 2016. we probably should be adding them both together
there's another also: allowTextAfterFloatingTableBreak.

@twsouthwick twsouthwick changed the title Add useWord2013TrackBottomHyphenation to CompatSettingNameValues Add missing values to `CompatSettingNameValues` Mar 23, 2020
@twsouthwick

This comment has been minimized.

Copy link
Collaborator Author

twsouthwick commented Mar 23, 2020

Added the additional ones you mentioned @tomjebo

@twsouthwick twsouthwick merged commit 17cedbb into OfficeDev:master Mar 24, 2020
3 checks passed
3 checks passed
OfficeDev.Open-XML-SDK #2.10.2-useWord2013TrackBottomHyphenation.13 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.