Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Build fails out of the box due to a missing webpack-cli dev dependency and other missing webpack configs #389
I'll submit a PR for this but writing up the issue first.
Update: Leaving this issue here for a bit to percolate because locking
It appears that out of the box, the build for add-ins (in this case an Outlook add-in) now fails.
Once I resolved the missing
Webpack has split out the cli into a
On Windows 10 | Node v10.14.1 | npm v6.4.1
Expected behavior: See local site served
Actual behavior: See the below error:
Steps to fix (I think?)
Also, I think it may be possible to lock in
added a commit
Dec 11, 2018
It appears to me that the break was introduced in webpack-dev-server v3.0.0, everything works if you set the version to v2.11.1 (last release before v3). However, that introduces a high severity vulnerability. Not sure if that is really that critical given this is for local testing.
UPDATE: the dev server crashes when you try to serve up the view on node version >= v11. Guessing this might be related to the vulnerability in 2.11.1
Given @richdizz's point, it sounds like the best way forward on this would be to bump to Webpack v4 and update things accordingly.
I may be willing to take a look at this in PR format if folks would be willing to offer some guidance along the way. Let me know if you're interested.