Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour styling #40

Merged
merged 11 commits into from May 22, 2019

Conversation

@coderkrishna
Copy link
Collaborator

commented May 9, 2019

Having the necessary changes made with regards to the fine tuning of the styling of the tour - which came from testing done on a Macbook

@coderkrishna coderkrishna requested a review from jotrick May 9, 2019

min-width: 96px;
margin: 90px 0px 0px 478px;
width: 96px;
margin: 90px 0px 0px 346px;

This comment has been minimized.

Copy link
@aosolis

aosolis May 16, 2019

Contributor

This is sketchy-- why does this have a 346px left margin? It looks like you might be using margin to position the button all the way to the right. Don't do that. Use something like flex layout instead.

Changing the class name from primary-button-back to secondary-button …
…and also making the necessary class reference changes in tour.html
Source/Icebreaker/Content/styles.css Outdated Show resolved Hide resolved
Source/Icebreaker/Content/styles.css Show resolved Hide resolved
Source/Icebreaker/Content/styles.css Show resolved Hide resolved
Source/Icebreaker/Content/styles.css Show resolved Hide resolved
Source/Icebreaker/Content/styles.css Outdated Show resolved Hide resolved
Source/Icebreaker/Content/styles.css Outdated Show resolved Hide resolved
Source/Icebreaker/Content/styles.css Outdated Show resolved Hide resolved
Source/Icebreaker/Content/styles.css Outdated Show resolved Hide resolved
Source/Icebreaker/Content/styles.css Show resolved Hide resolved
Source/Icebreaker/Content/tour.html Show resolved Hide resolved
Having the necessary changes made for PR #40 - this way all of the pi…
…xels are converted to rem; Having the necessary rules correctly set

@coderkrishna coderkrishna merged commit 5cf5dc5 into master May 22, 2019

1 check passed

license/cla All CLA requirements met.
Details

@coderkrishna coderkrishna deleted the v-prkris/styling-fine-tuning branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.