Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move initials logic out of Persona component and into utility #1090

Merged
merged 5 commits into from Feb 24, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Contributor

commented Feb 22, 2017

Pull request checklist

  • Addresses an existing issue: #0000
  • Include a change request file if publishing
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Description of changes

This pull request moves the initials logic to a utility, thus addressing one of the comments that @dzearing left on #760.

Focus areas to test

This change is just a refactor. No new functionality added. Everything is covered by existing unit tests.

c-w added some commits Feb 22, 2017

Move initials creation logic to utility
This will enable easy unit testing, re-use, etc. going forward.
@msftclas

This comment has been minimized.

Copy link

commented Feb 22, 2017

Hi @c-w, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@c-w

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2017

Putting this on the radar of @cliffkoh.

@cliffkoh
Copy link
Member

left a comment

Looks good, thank you!

cliffkoh and others added some commits Feb 23, 2017

@c-w

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2017

Pinging @cliffkoh to hit the merge button before the master branch advances again.

@cliffkoh cliffkoh merged commit 2443a37 into OfficeDev:master Feb 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.