Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve world-readiness of initials algorithm #1106
Pull request checklist
Description of changes
This change improves the world-readiness of the initials algorithm.
Specifically, it adds some special-case handling for:
Note that both of these world-readiness fixes are guaranteed to keep the existing contract that the initials function returns at most 2 characters.
Focus areas to test
Persona component, especially with non-Latin scripts.
@c-w Thanks for the PR. Just wondering, did you get a chance to test if 2 asian characters (Chinese or Korean) would fit within the Persona textboy? We could possibly augment the Persona example page to include such an example which would also provide a convenient way to validate this scenario...