Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Persona color swatches declaration #1157

Merged
merged 4 commits into from Mar 1, 2017

Conversation

Projects
None yet
4 participants
@c-w
Copy link
Contributor

commented Mar 1, 2017

Pull request checklist

  • Addresses an existing issue: #0000
  • Include a change request file if publishing
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Description of changes

Previously, there were two entries for lightPink and no entry for pink meaning that we're disproportionately more likely to create lightPink Persona bubbles and it's impossible to create pink Persona bubbles.

Focus areas to test

Just a constant change, no need for in-depth testing.

Fix typo in Persona color swatches declaration
Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.
@msftclas

This comment has been minimized.

Copy link

commented Mar 1, 2017

@c-w,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@c-w

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2017

Putting this onto your radar, @cliffkoh, since you reviewed changes to the Persona component previously.

@micahgodbolt
Copy link
Collaborator

left a comment

Yup, nice catch.

c-w added some commits Mar 1, 2017

@c-w

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2017

Pinging @micahgodbolt to hit the merge button before master advances again.

@micahgodbolt micahgodbolt merged commit b9778b2 into OfficeDev:master Mar 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cliffkoh

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

@c-w This is great, thanks for the patch.

aleksandrjPersonal added a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017

Fix typo in Persona color swatches declaration (OfficeDev#1157)
Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.

aleksandrjPersonal added a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017

Fix typo in Persona color swatches declaration (OfficeDev#1157)
Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.

aleksandrjPersonal added a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017

Fix typo in Persona color swatches declaration (OfficeDev#1157)
Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.

aleksandrjPersonal added a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017

Fix typo in Persona color swatches declaration (OfficeDev#1157)
Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.