Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Improve screenreader accessibility #1454

Merged
merged 2 commits into from Apr 11, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Contributor

commented Apr 11, 2017

Pull request checklist

  • Addresses an existing issue: #1452
  • Include a change request file if publishing
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Description of changes

When the dropdown is selected and we navigate via screen-reader keys (capslock + right arrow), we land on the caret icon which just announces "group". This is a confusing experience for screen reader users. This pull request marks the caret icon as hidden so that it gets excluded from the screen reader.

Focus areas to test

Test steps (verified manually on Dropdown.Basic.Example):

  1. Open test site in Edge, turn on Narrator, navigate to the dropdown. Press capslock + right arrow.
  2. Verify that caret "group" is not announced.

c-w added some commits Apr 11, 2017

@dzearing dzearing merged commit 6e14526 into OfficeDev:master Apr 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.