Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Add ability to open via space bar #1466

Merged
merged 4 commits into from Apr 11, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Contributor

commented Apr 11, 2017

Pull request checklist

  • Addresses an existing issue: #1445
  • Include a change request file if publishing
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Description of changes

Users who make use of our accessibility features will expect dropdowns to be controllable via space-bar in addition to the enter key. We currently only support the latter. This pull request adds support for the former.

Focus areas to test

Manually verified on Dropdown.Basic.Example:

  1. Navigate via keyboard to dropdown. Press space. Dropdown opens.
  2. Press space. Dropdown closes.

c-w added some commits Apr 11, 2017

Add ability to open/close dropdown via space bar
Note that unlike for other keys, we handle the open/close in onKeyUp to
prevent double triggering of the event.

Resolves #1445

@micahgodbolt micahgodbolt self-requested a review Apr 11, 2017

@micahgodbolt

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2017

Works great for me.

@micahgodbolt micahgodbolt merged commit faeb86c into OfficeDev:master Apr 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.