Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextualMenu: Document onRender accessibility requirement #1560

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Contributor

commented Apr 19, 2017

Pull request checklist

  • Addresses an existing issue: #0000
  • Include a change request file if publishing
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Description of changes

For keyboard accessibility, all custom-rendered context menus entries need to be focusable so that the FocusZone can set the appropriate tabIndex while navigating through the menu.

Previously, this requirement was not documented which made it very easy to inadvertently create non-accessible context menus. For example, the "ContextualMenu customization example" is currently not keyboard-accessible.

Hopefully this documentation update will make it easier for users to create accessible custom-rendered context menus.

Document onRender accessibility requirement
For keyboard accessibility, all custom-rendered context menus entries need to be
focusable so that the FocusZone can set the appropriate tabIndex while
navigating through the menu.

Previously, this requirement was not documented which made it very easy to
inadvertently create non-accessible context menus. For example, the
"ContextualMenu customization example" on
https://dev.office.com/fabric#/components/contextualmenu is currently not
keyboard-accessible.

@micahgodbolt micahgodbolt merged commit 3a32b3c into OfficeDev:master Apr 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the c-w:patch-1 branch Apr 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.