New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce prettier as pre-commit #5070

Merged
merged 43 commits into from Jun 4, 2018

Conversation

@Markionium
Collaborator

Markionium commented Jun 2, 2018

Pull request checklist

  • Include a change request file using $ npm run change
  • Microsoft Alias (if you have one): mapol

Description of changes

Prettier (will update description :D)

Markionium added some commits Apr 28, 2018

Merge branch 'master' into prettier-before-run
* master: (274 commits)
  Demo Page Refactor Part 1 (#5055)
  SplitButton: Add aria-roledescription (#5062)
  Add addins sketch toolkit link (#5052)
  Dropdown title (#4983)
  Allow for more control over event handling for keytips (#5064)
  Build time speed improvements (#4965)
  Coachmark: Positioning fixes (#4995)
  Applying package updates.
  Experiments/Nav component: display "show more" link only if there is atleast one hidden link (#5057)
  Add pointerup listener to exit keytip mode (#5051)
  Update PULL_REQUEST_TEMPLATE.md
  Update ISSUE_TEMPLATE.md
  Shimmer: resolve conflicts (#5034)
  Invalid ARIA attributes: Fix empty values (#5040)
  ComboBox: Correct invalid ARIA attributes. (#4873) (#5001)
  ComboBox: Fix submit pending value (#5048)
  FocusTrapZone - restore last focused descendant element (#4897)
  Applying package updates.
  Take 2 of the require.resolve change. This time using the "resolve" pkg (#5031)
  fixing webpack config to allow rush build to complete on a small VM (#5037)
  ...
Merge branch 'master' into applied-prettier
* master:
  MessageBar: More visible HC color for dismiss and expand buttons (#5061)
  Fix DetailsList accessibility and add more ARIA hooks (#5066)
  Update jest (#5068)

@Markionium Markionium requested a review from yiminwu as a code owner Jun 2, 2018

@kenotron

This comment has been minimized.

Show comment
Hide comment
@kenotron

kenotron Jun 4, 2018

Collaborator

This is awesome - I'm looking for a prettierrc / editorconfig file that will lock the team to some convention? Unless we've already all agreed on a convention?

Collaborator

kenotron commented Jun 4, 2018

This is awesome - I'm looking for a prettierrc / editorconfig file that will lock the team to some convention? Unless we've already all agreed on a convention?

@Markionium

This comment has been minimized.

Show comment
Hide comment
@Markionium

Markionium Jun 4, 2018

Collaborator

@kenotron It's currently here, but this is just based on the defaults and some small adjustments to keep them somewhat closer to the original fabric style. Feel free to suggest other things you think it should contain ;)

https://github.com/Markionium/office-ui-fabric-react/blob/1ac7cf81de07917d4299f5fbcda302ed430a03f2/packages/office-ui-fabric-react-tslint/prettier.config.js

Collaborator

Markionium commented Jun 4, 2018

@kenotron It's currently here, but this is just based on the defaults and some small adjustments to keep them somewhat closer to the original fabric style. Feel free to suggest other things you think it should contain ;)

https://github.com/Markionium/office-ui-fabric-react/blob/1ac7cf81de07917d4299f5fbcda302ed430a03f2/packages/office-ui-fabric-react-tslint/prettier.config.js

Markionium added some commits Jun 4, 2018

Merge branch 'master' into applied-prettier
* master:
  Add Fabric template to issue template. (#5080)
  Applying package updates.
  Callout: dismissal can now be done when you click on the documentElement (#5073)
  SpinButton: Events not firing #3282 (#4661)
  Typings bump (#5072)
  Groupedlist header customization (#4931)
  Moving a variable to be defined sooner so that it is there when failures occur.
@kenotron

This comment has been minimized.

Show comment
Hide comment
@kenotron

kenotron Jun 4, 2018

Collaborator

LGTM!

Collaborator

kenotron commented Jun 4, 2018

LGTM!

@kenotron kenotron self-assigned this Jun 4, 2018

@kenotron

LGTM

@mtennoe

This comment has been minimized.

Show comment
Hide comment
@mtennoe

mtennoe Jun 4, 2018

Collaborator

This is awesome Mark!

Collaborator

mtennoe commented Jun 4, 2018

This is awesome Mark!

@mtennoe

mtennoe approved these changes Jun 4, 2018

Show outdated Hide outdated .travis.yml Outdated

Markionium added some commits Jun 4, 2018

Merge branch 'master' into applied-prettier
* master:
  CommandBarPage: Remove FabricJS reference (#5087)
  Applying package updates.
  Reverse commit for PR #4897 (#5085)

@cliffkoh cliffkoh merged commit cfa7a19 into OfficeDev:master Jun 4, 2018

4 checks passed

bundlesize ../apps/test-bundle-button/dist/test-bundle-button.min.js: 37.98KB < maxSize 51.5KB gzip (same as master)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
screener Screener visual tests accepted
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment