IconButton: add color to IconButton so it can be themed. #6511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2018 12:49
Update snapshots
phkuo
approved these changes
Sep 28, 2018
2 tasks
cliffkoh
approved these changes
Oct 1, 2018
|
appears to be a bunch of visual regressions where icon colors change. Would seem to be related. |
|
@betrue-final-final to sign-off on screener changes |
|
Done. |
|
@micahgodbolt feel free to merge this one. It's awaiting the owner approval. Thanks! |
micahgodbolt
approved these changes
Oct 11, 2018
|
🎉 Handy Links: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Adding color to IconButton and change the color slot for hovered state as described in issue mentioned above.
Should also fix this Issue
Focus areas to test
@phkuo @betrue-final-final There are several other states for IconButton in this file... are they up for a change too?
Microsoft Reviewers: Open in CodeFlow