Add default card visualizations to SetupBanner and additional clean-up and styling. #6928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beginnings of hooking up card to cards
making default props optional add example
Added additional style locations Added final styling Added animations Adding strokeLineCap to IRawStyleBase
show all the different card states
remove button and link styles correct setup card skew
…c-react into brandonthomas/setupCards
dzearing
reviewed
Nov 1, 2018
| * SVG: The stroke-linecap attribute defines the shape to be used at the end of open subpaths when they are stroked. | ||
| * See SVG 1.1 https://www.w3.org/TR/SVG/painting.html#LineCaps | ||
| */ | ||
| strokeLinecap?: ICSSRule | 'butt' | 'round' | 'square'; |
Codecov Report
@@ Coverage Diff @@
## master #6928 +/- ##
=======================================
Coverage 74.89% 74.89%
=======================================
Files 859 859
Lines 24451 24451
Branches 5383 5383
=======================================
Hits 18312 18312
Misses 5675 5675
Partials 464 464Continue to review full report at Codecov.
|
packages/dashboard/src/components/SetupBanner/SetupCards.types.ts
Outdated
Show resolved
Hide resolved
Raghurk
reviewed
Nov 2, 2018
Raghurk
reviewed
Nov 2, 2018
packages/dashboard/src/components/SetupBanner/SetupCard.styles.ts
Outdated
Show resolved
Hide resolved
Raghurk
reviewed
Nov 2, 2018
packages/dashboard/src/components/SetupBanner/SetupCard.styles.ts
Outdated
Show resolved
Hide resolved
Referencing font size styles
|
@dzearing , once the checks finish, who can help me merge this in? |
|
🎉 Handy Links: |
|
🎉 Handy Links: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeworking with DZearing to get a change file as my environment i barfing on this. If we can't figure it out he'll submit one for me.
Description of changes
Focus areas to test
Microsoft Reviewers: Open in CodeFlow