Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove me as codeowner #9764

Merged

Conversation

jordandrako
Copy link
Contributor

@jordandrako jordandrako commented Jul 10, 2019

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

My last day is 7/11, so I'm removing myself as code owner of the fabric website. Thank you @ecraig12345 and good luck!

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

Hello @jordandrako!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@size-auditor
Copy link

size-auditor bot commented Jul 10, 2019

Size Auditor did not detect a change in bundle size for any component!

@msft-github-bot
Copy link
Contributor

Component Perf Analysis:

Scenario Master Samples * PR Samples *
BaseButton 776 848
BaseButton (experiments) 1675 1650
DefaultButton 1105 1094
DefaultButton (experiments) 1860 1867
DetailsRow 5493 5504
DetailsRow without styles 5248 5142
DocumentCardTitle with truncation 41619 43937
MenuButton 2067 2123
MenuButton (experiments) 4946 4953
PrimaryButton 1383 1399
PrimaryButton (experiments) 2357 2406
SplitButton 3899 3866
SplitButton (experiments) 9457 9367
Stack 518 517
Stack with Intrinsic children 2059 2072
Stack with Text children 5628 5727
Text 421 432
Toggle 986 981
Toggle (experiments) 2511 2565
button 80 68
* Sample counts can vary by up to 30% and shouldn't be used solely for determining regression. For more information please see the Perf Testing wiki.

Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to see you go (it's been great working with you)! Best wishes for your next job!

@khmakoto
Copy link
Member

@msft-github-bot wait 1 minute.

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 10 Jul 2019 22:56:24 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@msft-github-bot msft-github-bot merged commit 45ee47e into microsoft:master Jul 10, 2019
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants