Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to language-switch between TS and Python #747

Merged
merged 1 commit into from Jul 31, 2019

Conversation

Zlatkovsky
Copy link
Member

(When settings are set for jupyter)

(When settings are set for jupyter)
@Zlatkovsky
Copy link
Member Author

@shaofengzhu , there is now a language-switcher in the bottom right (which before simply displayed the language but didn't let you switch it)

image

For it to become a dropdown, note that you'll need the appropriate settings already set. I.e.:

jupyter.url: 'http://localhost:8888'
jupyter.token: exceljupyter
jupyter.notebook: HelloWorld.ipynb

@Zlatkovsky
Copy link
Member Author

@shaofengzhu , I will merge this in tomorrow morning. In the meantime, you can either cherry-pick my commit into yours (but it might get messy), or just tweak the YAML like we did before (to have it say language: python, just like in https://gist.github.com/Zlatkovsky/3890dae8bebb53658e04efbbb6f3f46d.

I'll get it into alpha before tomorrow's demo, though.

@nico-bellante , since this had to do with actions and selectors and etc, would appreciate your review -- though it's also fine if you want to give your feedback after I check in (since I want this in alpha for the demo tomorrow anyway), and I can fix it later.

@Zlatkovsky
Copy link
Member Author

@nico-bellante , going ahead and merging. But would still appreciate your post-factum review if you have the time.

@Zlatkovsky Zlatkovsky merged commit 9cc7f0c into master Jul 31, 2019
@Zlatkovsky Zlatkovsky deleted the zlatkovsky/python-switcher branch March 24, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant