Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSF postal address. #609

Closed
wants to merge 1 commit into from

Conversation

jelmer
Copy link
Contributor

@jelmer jelmer commented Apr 6, 2019

Update FSF postal address.

@jelmer jelmer requested a review from chris001 as a code owner April 6, 2019 21:05
@nicolas33
Copy link
Member

Thanks; applied. Will be there in the next release.

@nicolas33 nicolas33 closed this Apr 6, 2019
@@ -14,7 +14,7 @@
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this has the same problem as the previous address, it could change at some point and it would require updating tons of source code again. Please use instead something like this:

 You should have received a copy of the GNU General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.

@jelmer please update your scripts to this variant! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @guillemj, that's a good point. I'll update the script to point at the URL before I run it again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the URI is less prone to change than the postal address.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the GPL-3 already uses the URL instead of the postal address. And an URL has the advantage of supporting being redirected in case they decided to change it, which seems extremely unlikely given the amount of references out there, compared to physical relocation which might be a necessity. :)

I personally switched all projects I'm involved with to use the URL some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants