New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight selected items #38

Merged
merged 7 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@Ofir-Smuha
Copy link
Owner

Ofir-Smuha commented Jan 27, 2019

  • Highlight selected items (support multi select)
  • Not supporting yet - handling selected items from URL

@Ofir-Smuha Ofir-Smuha requested a review from morsdyce Jan 27, 2019

Show resolved Hide resolved src/components/common/ListItem.js Outdated
@@ -36,6 +36,7 @@ type State = {

class SortIssues extends Component<ConnectedProps & OwnProps, State> {
state = {
repoAssignees: this.props.repoAssignees,

This comment has been minimized.

@morsdyce

morsdyce Jan 28, 2019

Collaborator

why are you saving repoAssignees on the state?

This comment has been minimized.

@Ofir-Smuha

Ofir-Smuha Jan 28, 2019

Author Owner

Because of the functionality of is-selected. I'm passing the repoAssignees from props to state and from the state to the "ListSelect" (generic component) and manipulating the data every time an item is clicked.

itemsKey,
isMultiSelect
) => {
this.handleUrlChange(parameter, value, closeModalKey);

This comment has been minimized.

@morsdyce

morsdyce Jan 28, 2019

Collaborator

this looks over complicated, please explain what is the meaning of this code

This comment has been minimized.

@Ofir-Smuha

Ofir-Smuha Jan 28, 2019

Author Owner

handleItemSelect function handling the item click, firstly calling the handleUrlChange for fetching the required data from Github and editing the search params in the url, then handling toggling the selected item from a specific items array (e.g repoAssignees from your comment above)

This comment has been minimized.

@Ofir-Smuha

Ofir-Smuha Jan 30, 2019

Author Owner

Changed

@morsdyce

This comment has been minimized.

Copy link
Collaborator

morsdyce commented Jan 28, 2019

@morsdyce morsdyce merged commit dd9f28e into release_candidate Feb 6, 2019

@morsdyce morsdyce deleted the highlight-selected branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment