New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto search #42

Merged
merged 6 commits into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@Ofir-Smuha
Copy link
Owner

Ofir-Smuha commented Jan 30, 2019

  • Auto search Github repos

@Ofir-Smuha Ofir-Smuha requested a review from morsdyce Jan 30, 2019

Show resolved Hide resolved src/components/common/AutoSearch.js Outdated
}

componentDidUpdate(prevProps) {
if (prevProps.location.pathname !== this.props.location.pathname) {

This comment has been minimized.

@morsdyce

morsdyce Feb 6, 2019

Collaborator

why is this update based on url rather than an id for the issue that changed?

This comment has been minimized.

@Ofir-Smuha

Ofir-Smuha Feb 7, 2019

Author Owner

Because its the issues page (not a single issue) so the only reference change is the url params (which by, it fetches the requested issues)

@morsdyce morsdyce merged commit 6d8ee3f into release_candidate Feb 18, 2019

@morsdyce morsdyce deleted the auto-search branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment