Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Limited to Clamp #209

Ogeon opened this issue Apr 3, 2021 · 0 comments · Fixed by #210

Rename Limited to Clamp #209

Ogeon opened this issue Apr 3, 2021 · 0 comments · Fixed by #210


Copy link

Ogeon commented Apr 3, 2021

I think "Limited" sounds like there will be "limited" and "unlimited" color spaces, but the reality is not as clear cut. It's more that most of them have a typical range. I think it's better to rebrand the trait to an "action" trait, by naming it with a verb, and letting the details be implementation specific. So it will still make sense to have a clamp method even if a color space is only limited by convention, but still could have a theoretically infinite range.

What to do:

  • Rename the trait
  • Rename is_valid to is_within_bounds or something more appropriate
  • Update documentation and examples
@Ogeon Ogeon added this to the 0.6.0 milestone Apr 3, 2021
@bors bors bot closed this as completed in 6795d97 Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging a pull request may close this issue.

1 participant