Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image and approx crate dependency #104

Merged
merged 5 commits into from
May 28, 2018
Merged

Update image and approx crate dependency #104

merged 5 commits into from
May 28, 2018

Conversation

Veykril
Copy link
Contributor

@Veykril Veykril commented May 27, 2018

Closes #101 and closes #100. I accidentally put both pull requests together.

@Veykril Veykril changed the title Update image crate dependency Update image and approx crate dependency May 28, 2018
Copy link
Owner

@Ogeon Ogeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two in one! Nice! Other than what I think is a logic mistake, it looks really good. Thanks!

fn default_max_ulps() -> u32 {
T::default_max_ulps()
fn abs_diff_ne(&self, other: &Self, epsilon: T::Epsilon) -> bool {
$( self.$element.abs_diff_ne(&other.$element, epsilon) )&&+
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be delimited with ||, since it would be the inverse of abs_diff_eq. Same for the other *_ne implementations.

Copy link
Contributor Author

@Veykril Veykril May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that should be ||, looks it was implemented wrong previously as well because the *_ne were using &&. I just adapted that by accident. Fixed it now if I didnt miss anything.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good thing it was discovered then.

@Ogeon
Copy link
Owner

Ogeon commented May 28, 2018

I think that was all. Great!

bors r+

bors bot added a commit that referenced this pull request May 28, 2018
104: Update image and approx crate dependency r=Ogeon a=Veykril

Closes #101 and closes #100. I accidentally put both pull requests together.

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 28, 2018

Build succeeded

@bors bors bot merged commit e429094 into Ogeon:master May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uppdate image dependency Update approx dependency
2 participants