Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round to nearest instead of down when converting components to integers. #135

Merged
merged 1 commit into from
Jul 7, 2019

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Jul 7, 2019

This is the rounding part of #117, rebased to include changes on master since it was submitted. Big thanks to @PeterHatch for making me realize my mistake and for submitting the fix.

@Ogeon
Copy link
Owner Author

Ogeon commented Jul 7, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 7, 2019
135: Round to nearest instead of down when converting components to integers. r=Ogeon a=Ogeon

This is the rounding part of #117, rebased to include changes on `master` since it was submitted. Big thanks to @PeterHatch for making me realize my mistake and for submitting the fix.

Co-authored-by: Peter Hatch <petershatch@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 7, 2019

Build succeeded

@bors bors bot merged commit e37a385 into master Jul 7, 2019
@bors bors bot deleted the rounding branch July 7, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants