Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade phf to 0.9 and enable named_from_str for no_std #235

merged 1 commit into from
Jul 11, 2021


Copy link

@Ogeon Ogeon commented Jul 11, 2021

While upgrading phf to 0.9, I also realized that it could easily be made available with no_std by switching to the macro instead of phf_codegen.

I also noticed that I forgot to add named_gradients in the readme.

Copy link

Benchmark for 72c67bf

Click to view benchmark
Test PR Benchmark Master Benchmark %
Cie family/lab to lch 3.0±0.00µs 3.0±0.00µs 0.00%
Cie family/lab to xyz 815.7±0.46ns 817.5±0.42ns -0.22%
Cie family/lch to lab 2.1±0.00µs 2.1±0.00µs 0.00%
Cie family/linsrgb to xyz 3.2±0.01µs 3.2±0.00µs 0.00%
Cie family/xyz to lab 9.1±0.02µs 9.2±0.01µs -1.09%
Cie family/xyz to yxy 616.9±0.36ns 524.7±0.28ns +17.57%
Cie family/yxy to xyz 530.4±0.46ns 524.7±0.72ns +1.09%
Matrix functions/matrix_inverse 11.0±0.00ns 11.4±0.01ns -3.51%
Matrix functions/multiply_3x3 9.1±0.05ns 9.1±0.00ns 0.00%
Matrix functions/multiply_rgb_to_xyz 4.1±0.00ns 4.1±0.00ns 0.00%
Matrix functions/multiply_xyz 4.1±0.00ns 4.1±0.00ns 0.00%
Matrix functions/multiply_xyz_to_rgb 4.1±0.00ns 4.1±0.00ns 0.00%
Matrix functions/rgb_to_xyz_matrix 21.5±0.01ns 21.5±0.11ns 0.00%
Rgb family/hsl to hsv 619.8±0.28ns 621.9±2.29ns -0.34%
Rgb family/hsl to linear hsl 8.2±0.00µs 8.2±0.01µs 0.00%
Rgb family/hsl to rgb 2.1±0.00µs 2.1±0.00µs 0.00%
Rgb family/hsv to hsl 1012.7±2.89ns 967.3±3.56ns +4.69%
Rgb family/hsv to hwb 229.8±0.08ns 230.0±0.15ns -0.09%
Rgb family/hsv to linear hsv 7.6±0.01µs 7.6±0.00µs 0.00%
Rgb family/hsv to rgb 2.1±0.01µs 2.1±0.00µs 0.00%
Rgb family/hwb to hsv 478.1±0.26ns 478.1±0.26ns 0.00%
Rgb family/hwb to linear hwb 9.3±0.01µs 9.3±0.06µs 0.00%
Rgb family/linear hsl to hsl 8.7±0.01µs 8.7±0.01µs 0.00%
Rgb family/linear hsv to hsv 8.2±0.01µs 8.2±0.04µs 0.00%
Rgb family/linear hwb to hwb 10.0±0.01µs 10.0±0.01µs 0.00%
Rgb family/linsrgb to rgb 4.0±0.02µs 4.0±0.00µs 0.00%
Rgb family/linsrgb_f32 to rgb_u8 5.4±0.01µs 5.4±0.01µs 0.00%
Rgb family/rgb to hsl 742.6±3.12ns 742.1±6.25ns +0.07%
Rgb family/rgb to hsv 565.4±0.24ns 565.2±0.31ns +0.04%
Rgb family/rgb to linsrgb 4.3±0.00µs 4.2±0.00µs +2.38%
Rgb family/rgb_u8 to linsrgb_f32 4.6±0.00µs 4.6±0.00µs 0.00%
Rgb family/xyz to linsrgb 7.0±0.00µs 7.6±0.01µs -7.89%

Copy link
Owner Author

Ogeon commented Jul 11, 2021

bors r+

Copy link

bors bot commented Jul 11, 2021

Build succeeded:

@bors bors bot merged commit c84fb4e into master Jul 11, 2021
@bors bors bot deleted the phf_0.9 branch July 11, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant