Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing version strings issue #32

Closed
ItsHardToTakeUsername opened this issue Jul 20, 2019 · 4 comments

Comments

@ItsHardToTakeUsername
Copy link

commented Jul 20, 2019

sfos-upgrade fails to work on Inoi R7.

[root@Sailfish nemo]#  sfos-upgrade 3.1.0.11
Notice: The installed version 3.0.0.11+omp0.1.3.10 is smaller than the one curr
ently set for SSU (3.1.0.11).
A possible reason for this is, that the \'sailfish-osupdateservice osupdate-che
ck\' invoked by osupdate-check.service (which is regularly triggered by osupdat
e-check.timer) does more than just checking (observed with SailfishOS 3.0.2 and
earlier): E.g., setting ssu to the recent release version or next stop release
.
Never mind, the version for SSU will be set correctly again, later on.

/usr/bin/sfos-upgrade: line 74: [: 11+omp0: integer expression expected
/usr/bin/sfos-upgrade: line 78: [: 11+omp0: integer expression expected
Warning from function compare_versions: Version strings "3.0.0.8" and "3.0.0.11
+omp0.1.3.10" are not comparable!
[root@Sailfish nemo]#
@Olf0

This comment has been minimized.

Copy link
Owner

commented Jul 26, 2019

Oh, version outputs an unexpected format of the version string on your Inoi R7: 3.0.0.11+omp0.1.3.10
AFAIK, the version strings of all SailfishOS versions supplied directly by Jolla (i.e., when a SailfishOS license was bought directly from Jolla) always were in the format a.b.c.d (e.g. 3.0.0.11), but not a.b.c.d+xyze.f.g.h

As I do not have access to an Inoi R7, I do need more information to understand how to handle this properly.

  1. Is this a regular, standard Inoi R7? I.e., with no special SailfishOS version; just what Inoi distributes to regular (i.e. personal) customers?
  2. Have you subscribed to Jolla's "EA (early access)" release channel?
    I even do not know, if that is possible with a third party SailfishOS device (e.g. by Inoi, Intex, Jala), but obviously so as you tried to install SFOS 3.1.0 before its "GA (general availability)" release.
  3. Do you know, if Inoi devices always carried such an "+omp" extension of the version string? ("omp" may mean "Open Mobile Russia".)
  4. a. Do you know, if it is correct to upgrade at the command line using a regular version string on such devices?
    b. Specifically, have you upgraded SailfishOS on your device successfully per ssu re <a.b.c.d> && version dup or sfos-upgrade <a.b.c.d> in the past?
    (I am concerned that their correct usage may be with <a.b.c.d+ompe.f.g.h> on a device as yours.)
@Olf0 Olf0 self-assigned this Jul 28, 2019
@Olf0

This comment has been minimized.

Copy link
Owner

commented Jul 28, 2019

@ItsHardToTakeUsername, I posted a RFI at OpenRepos, but nevertheless I still would appreciate feedback from you WRT above questions 1 to 4, plus the output of version, ssu re and ssu s.

Olf0 added a commit to Okxa/sfos-upgrade that referenced this issue Aug 13, 2019
Enhanced fix for issue Olf0#35, plus Olf0#32.
Olf0 added a commit that referenced this issue Aug 13, 2019
* changed to detect installed version via regular expressions. (works when the version is like 1.2.3.4), to fix when `version` reports architechture: `SailfishOS 1.0.8.19 (Tahkalampi) (armv7hl)`

* Update sfos-upgrade

Enhanced fix for issue #35, plus #32.
@Olf0

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

"Fixed" per commit b8a7645 from PR #33.

Note that, without the above requested information, this is a "shot in the dark": The issue is resolved at the surface, but the consequences are unknown for devices affected by this issue #32!

@Olf0 Olf0 added the fixed label Aug 13, 2019
@Olf0

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

Released as v3.2-1 and uploaded a built RPM for testing.

@Olf0 Olf0 closed this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.