Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what do you think? #3817

Merged
merged 2 commits into from Oct 26, 2020
Merged

what do you think? #3817

merged 2 commits into from Oct 26, 2020

Conversation

goldenpipes
Copy link
Contributor

basically got rid of some extra padding to the layout change buttons. and hid them on mobile since they it doesn't really need to be there on mobile.

image

let me know.

@twanariens
Copy link
Collaborator

Well you definately got rid of some padding :D But. Would love to see a little bit of padding between the Movies/Combined/TV bar and the Popular/Trending/Upcoming bar.

And how does it hold up when you resize your screen? (like 2560 x 1440)

@goldenpipes
Copy link
Contributor Author

1440p SCREENSHOT

good catch on the padding between the selector's forgot to add that back in

image

@twanariens
Copy link
Collaborator

Look amazing. Now if you can try and center the search bar. We should make some users happy :D

@tidusjar tidusjar merged commit 0372b30 into feature/v4 Oct 26, 2020
@tidusjar tidusjar deleted the discovery-layout-selection branch October 26, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants