New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generate instead of setgenerate #137

Closed
dexX7 opened this Issue Dec 9, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@dexX7
Copy link
Member

dexX7 commented Dec 9, 2016

The 0.13 based Omni Core currently forwards requests for setgenerate, but ultimately OmniJ should use the new RPC generate, to generate a block.

@msgilligan

This comment has been minimized.

Copy link
Member

msgilligan commented Dec 9, 2016

I thought I had already done this -- maybe I missed some cases? I'll double-check -- and I agree.

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Dec 9, 2016

Wait, maybe I missed the update. I haven't actually tested it without the forward.

@msgilligan

This comment has been minimized.

Copy link
Member

msgilligan commented Dec 9, 2016

There is still some cleanup around generate / setgenerate but I'm pretty sure setgenerate is no longer being used in any of the RegTests.

I just now made some further (final?) changes in this area:

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Dec 10, 2016

Looks good to me! Even without the forward (OmniLayer/omnicore#440) the OmniJ tests pass.

@dexX7 dexX7 closed this Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment