Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activation and trading tests for all-pair trading #124

Merged
merged 4 commits into from May 11, 2016

Conversation

Projects
None yet
2 participants
@dexX7
Copy link
Member

dexX7 commented Apr 30, 2016

This pull request adds tests for the trading of non-Omni pairs.

Once the feature with identifier 8 is active, the distributed token exchange can be used with non-Omni tokens.

During the grace period, the old rules are still in place.

Please note: unfortunally unit prices are no longer nominated in Omni, but instead based on forsale/desired, which is different from our release version.

@msgilligan: currently I simply assume the tests are run with an Omni Core version with the feature and the updated unit price meaning (currently pending as OmniLayer/omnicore#361), but the tests will fail with 0.0.10. What do you suggest to tackle this? Ideally we'd provide compatibility for both versions.

dexX7 added some commits Apr 30, 2016

Invert unit prices of MetaDEx tests
To prepare all-pair trading, unit prices are no longer nominated in Omni, but instead based on forsale/desired.
Add activation tests for all-pair trading on MetaDEx
Adds test for the activation of all-pair trading on the distributed token exchange.

Once the feature with identifier 8 is active, the distributed token exchange can be used with non-Omni tokens.

During the grace period, the old rules are still in place.

Note: this test is only successful with a clean state, and requires that the feature is initially disabled!
Add minimum version requirement to all-pair test
The all-pair trading test, as well as the updated unit prices in the MetaDEx test, are only executed, if the Omni Core version is equal or greater than 0.0.11.

@dexX7 dexX7 force-pushed the dexX7:rpc-test-all-pair branch from 96a0428 to 547f552 May 1, 2016

@dexX7

This comment has been minimized.

Copy link
Member Author

dexX7 commented May 1, 2016

I added a minimum version requirement via 96a0428 to support both 0.0.10 and 0.0.11. Please let me know, if I should move or refactor.

From my side this submission is good to go.

@msgilligan msgilligan merged commit 18fee68 into OmniLayer:master May 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.