Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Balance RPCs return empty balance entries #257
I think the entries should either be filtered out, or removed (but not on the RPC layer).
Empty balance entries are not persisted, so this only affects the runtime state.
Related: OmniLayer/OmniJ#116 (comment)
Yep, since we loop the tally and an empty address persists during runtime - but that begs the bigger question: when we
I'm not sure what you mean by "not on the RPC layer" mate, sorry! I would say:
This is what I was referring to.
Let me rephrase: it probably would be not a good, if we start to remove/delete tally entries directly in the RPCs. Filtering can be done on the RPC layer though. :)
I'd say: let's filter them for now.