New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Omni Core client version as integer #318

Merged
merged 1 commit into from Dec 30, 2015

Conversation

Projects
None yet
2 participants
@dexX7
Copy link
Member

dexX7 commented Dec 30, 2015

Expose Omni Core client version as integer to make it easier to compare the actual client version to activation transactions.

This resolves #312.

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Dec 30, 2015

Reviewed & tested, works fine:

$ src/omnicore-cli omni_getinfo
{
    "omnicoreversion_int" : 1000000,
    "omnicoreversion" : "0.0.10-rel",
    "mastercoreversion" : "0.0.10-rel",
    "bitcoincoreversion" : "0.10.4",
    "commitinfo" : "70dce16",
    "block" : 391013,
    "blocktime" : 1451503787,
    "blocktransactions" : 0,
    "totaltrades" : 61,
    "totaltransactions" : 37950,
    "alerts" : [
    ]
}

OK to merge :)

@dexX7 dexX7 force-pushed the dexX7:oc-0.10.1-rpc-expose-version branch to 6385281 Dec 30, 2015

@dexX7 dexX7 merged commit 6385281 into OmniLayer:omnicore-0.0.10 Dec 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dexX7 added a commit that referenced this pull request Dec 30, 2015

Merge pull request #318
6385281 Expose Omni Core client version as integer (dexX7)

@dexX7 dexX7 modified the milestone: 0.0.10.1 Dec 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment