Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix and update seed blocks up to block 390000 #324
Yeah, I messed up a little and hadn't updated my local branch, which also meant I wasn't actually verifying against the new 390,000 checkpoint (which turned up another seed block issue).
Fixed up & corrected, just running a testing pass now and then will push :)
OK, that should be it now - rebased and sorted the remaining seed block issues :)
To test, I use
Sure - I cheated hehe... The hooks I was using were hacky and seemed to give bad results, so I just used Chest's database instead this time around... FYI I intend to revisit the upgraded consensus hashing PR and include in it the ability to generate seed block lists directly over RPC by querying levelDB so we've got a defined and re-usable process (to be honest I found this whole thing very long winded, manual and error prone this time - I don't remember it being like that last time I did it, but that's probably why last time's results were faulty! So having a coded up process for seed block generation along with a more in-depth checkpointing will make me feel a bit better about using seed blocks).
If I'm not mistaken, then we both created seedblock lists and ended up with different results (mostly related to structurally valid/invalid IIRC etc.) and I manually added hooks and whatnot. :)
Having a more easy and straight forward way to deal with this would definitely be a big win!
Please let me know once this is good to go. I'm currently still unable to test it myself, but given the effort and testing you're doing, I'm fine with a merge, especially since the CI server also provides additional feedback (and checkpoint tests) due to the reparsing. :)