New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Bitcoin tab in Send page when handling Bitcoin URIs #327

Merged
merged 1 commit into from Jan 4, 2016

Conversation

Projects
None yet
2 participants
@zathras-crypto
Copy link

zathras-crypto commented Jan 4, 2016

The handlePaymentRequest function of the wallet view has no knowledge of the extra Omni tab we've implemented and since the Omni tab is now the default, Bitcoin URIs do not necessarily activate the Bitcoin tab of the Send page.

This PR serves to automatically switch the tab in the Send page to Bitcoin when handling Bitcoin URIs.

Resolves #311.

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Jan 4, 2016

Is there a quick way to test this?

I'd like to underline: it's great to have you "back"! :) Really pushing the spirit and motivation, seeing all your pull requests coming in. :)

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jan 4, 2016

Is there a quick way to test this?

Sure, just run the command:

src/qt/omnicore-qt bitcoin:mrhz5ZgSF3C1BSdyCKt3gEdhKoRL5BNfJV?amount=0.01

And it should automatically switch to the Bitcoin tab with the payment details populated. You can then 'clear all', switch back to the Omni tab and run that command again - it should do the same (populate and switch tabs).

I'd like to underline: it's great to have you "back"! :) Really pushing the spirit and motivation, seeing all your pull requests coming in. :)

Hehe, thanks dude :) With me focusing on 'Chest v6 and experimenting with API stuff and health stuff and my trip overseas I've probably been a bit all over the place, but definitely getting back into the swing of things now!

@dexX7 dexX7 added this to the 0.0.10.1 milestone Jan 4, 2016

@zathras-crypto zathras-crypto force-pushed the zathras-crypto:0.0.10.1-Z-FixPaymentRequestTab branch to 7fc0538 Jan 4, 2016

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jan 4, 2016

Rebased for merge :)

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Jan 4, 2016

Sure, just run the command:

Ah, that's easy. I'm currently building. :)

@dexX7 dexX7 merged commit 7fc0538 into OmniLayer:omnicore-0.0.10 Jan 4, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

dexX7 added a commit that referenced this pull request Jan 4, 2016

Merge pull request #327
7fc0538 Switch to Bitcoin tab in Send page when handling Bitcoin URIs (zathras-crypto)

@zathras-crypto zathras-crypto deleted the zathras-crypto:0.0.10.1-Z-FixPaymentRequestTab branch May 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment