New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and add unit tests for new consensus hashes #328

Merged
merged 3 commits into from Jan 4, 2016

Conversation

Projects
None yet
2 participants
@dexX7
Copy link
Member

dexX7 commented Jan 4, 2016

This pull request adds and updates the unit tests for consensus hashes and checkpoints.

In particular, the string generation is tested with empty objects and populated objects. The impact on the whole state (and thus consensus hash generation) is not well tested, due to the unhandiness of modifying the state (e.g. adding new orders etc.).

The checkpoint for a blank state and the mainnet genesis block was updated and is tested.

dexX7 added some commits Jan 4, 2016

@dexX7 dexX7 added this to the 0.0.10.1 milestone Jan 4, 2016

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jan 4, 2016

Brilliant, thanks dude! :)

I reviewed & tested and confirm all tests pass:

$ src/test/test_omnicore 
Initializing Omni Core v0.0.10-rel [unittest]
Loading trades database: OK
Loading send-to-owners database: OK
Loading transactions database: OK
Loading smart property database: OK
Loading persistent state: NONE (no usable previous state found)
Exodus balance: 0.00000000 OMNI
Omni Core initialization completed
Running 369 test cases...
Omni Core shutdown completed

*** No errors detected

OK to merge :)

@dexX7 dexX7 merged commit d0af0ac into OmniLayer:omnicore-0.0.10 Jan 4, 2016

dexX7 added a commit that referenced this pull request Jan 4, 2016

Merge pull request #328
d0af0ac Update and add unit tests for new consensus hashes (dexX7)
f374398 Get property from sell offer directly from object (dexX7)
a4ea788 Add checkpoint for genesis block (dexX7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment