New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seed blocks for structurally invalid transactions + reformat #332

Merged
merged 1 commit into from Jan 5, 2016

Conversation

Projects
None yet
2 participants
@zathras-crypto
Copy link

zathras-crypto commented Jan 5, 2016

This PR removes seed blocks that after additional testing have been deemed unnecessary as they only contain structurally invalid transactions.

Removing unneeded seed blocks serves to optimize initial parsing by removing unnecessary work.

Revised seed block list to 390000 passes all checkpoints to 390000.

Resolves #329.

@zathras-crypto zathras-crypto added this to the 0.0.10.1 milestone Jan 5, 2016

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Jan 5, 2016

Did you try a test parse by any chance? :)

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jan 5, 2016

Did you try a test parse by any chance? :)

I did indeed... (a --startclean with the new seedblock list, passed all checkpoints) - did I miss something?

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Jan 5, 2016

Haha, no, this was not where I was going. Just wanted to make sure! :)

@dexX7 dexX7 merged commit 906c3e9 into OmniLayer:omnicore-0.0.10 Jan 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dexX7 added a commit that referenced this pull request Jan 5, 2016

Merge pull request #332
906c3e9 Remove seed blocks for structurally invalid transactions + reformat (zathras-crypto)

@zathras-crypto zathras-crypto deleted the zathras-crypto:0.0.10.1-Z-RemoveStructurallyInvalidSeedBlocks branch May 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment