New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable logging on Windows to speed up CI RPC tests #335

Merged
merged 2 commits into from Jan 6, 2016

Conversation

Projects
None yet
2 participants
@dexX7
Copy link
Member

dexX7 commented Jan 5, 2016

To speed up the automated tests via Travis CI, the logging is disabled.

This comes at the cost of potentially unnoticed errors due to logging format specifiers.

Note: this is just a test, which hopefully shows a significant difference.

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Jan 5, 2016

Wow, this can't be right.. or can it?

It takes roughly an hour less for the Windows builds and cuts down the time to around 9 minutes from up to 1:21 hours:

edit: I mean, enabling all debug options is really heavy, because every UTXO selection is written, all the consensus hashes etc..

edit: force pushed a rebased version to trigger the tests once again.

@dexX7 dexX7 added status: ready and removed status: on hold labels Jan 5, 2016

@dexX7 dexX7 force-pushed the dexX7:oc-0.10.1-test-no-logging branch to 34186d1 Jan 5, 2016

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Jan 5, 2016

The new run confirmed the fast testing times:

https://travis-ci.org/OmniLayer/omnicore/builds/100416275

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jan 6, 2016

Wow - that's awesome!

Perhaps we can have a refined set of debugging options that is optimized? FYI with the upgraded consensus hashing system offering more granularity using -omnidebug=all will generate a consensus hash after every Omni transaction now so it's pretty slow...

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Jan 6, 2016

Perhaps we can have a refined set of debugging options that is optimized?

We could. On the other hand: we never see the logs at all from the Travis runs, so it really just is about spotting errors with the logging itself (e.g. two format specifiers in a log text, but only one value provided usually results in a crash), so I'm not sure, if it's really worth.

@dexX7 dexX7 modified the milestone: 0.0.10.1 Jan 6, 2016

@dexX7 dexX7 force-pushed the dexX7:oc-0.10.1-test-no-logging branch to 9032a77 Jan 6, 2016

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Jan 6, 2016

I had another idea: 9032a77

The heavy logging remains enabled for all builds except Windows, where the impact is most notable.

@dexX7 dexX7 changed the title Disable logging to speed up RPC tests Disable logging on Windows to speed up CI RPC tests Jan 6, 2016

@dexX7

This comment has been minimized.

@dexX7 dexX7 merged commit 9032a77 into OmniLayer:omnicore-0.0.10 Jan 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dexX7 added a commit that referenced this pull request Jan 6, 2016

Merge pull request #335
9032a77 Only use minimum logging for Windows CI tests (dexX7)
34186d1 Disable logging to speed up RPC tests (dexX7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment