New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default maximum OP_RETURN size to 80 bytes #336

Merged
merged 2 commits into from Jan 6, 2016

Conversation

Projects
None yet
3 participants
@dexX7
Copy link
Member

dexX7 commented Jan 6, 2016

This is a backport of bitcoin#5286:

The maximum size for OP_RETURN outputs used to be 80 bytes, then got changed to 40 bytes to be on the safe side. We have now been running with 40 bytes for about 9 months, and nothing catastrophic happened to the Blockchain, so I am proposing to increase it back to 80 bytes.

Also, that value is now configurable through the datacarriersize option, so miners who want to stay on 40 bytes (or any other value) can easily do so.

This change was adopted in Bitcoin Core 0.11.0, and based on bitnodes.21.co only a minority still uses the old default of 40 bytes.

Flavien added some commits Nov 14, 2014

Change the default maximum OP_RETURN size to 80 bytes
The value can be changed through the '-datacarriersize' option, this
is modifying the default value for that option.
Update the 'test_IsStandard' unit test
The maximum length for the payload of an OP_RETURN output is now
80 bytes, and unit tests must be modified to account for the change.

@dexX7 dexX7 added this to the 0.0.10.1 milestone Jan 6, 2016

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jan 6, 2016

Great, more Class C space is a great thing and since this is already in upstream I'm fine with it :)

UTAck, but OK to merge :)

@dexX7 dexX7 merged commit 6c6859f into OmniLayer:omnicore-0.0.10 Jan 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dexX7 added a commit that referenced this pull request Jan 6, 2016

Merge pull request #336
6c6859f Update the 'test_IsStandard' unit test (Flavien Charlon)
a8cd862 Change the default maximum OP_RETURN size to 80 bytes (Flavien Charlon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment