Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable the trading UI #375

Merged
merged 1 commit into from May 21, 2016

Conversation

Projects
None yet
2 participants
@zathras-crypto
Copy link

zathras-crypto commented May 16, 2016

The current MetaDEx UI in Omni Core was designed for trading where one side of the pair is always Omni. As such it takes several actions and makes several coding assumptions based on knowledge that one side of the trade will always be Omni.

Since 0.11 provides the ability to trade all pairs once activated, this changes the rules and makes the current UI a risk.

This PR thus disables the current trading interface, and leaves the rest of the UI as is.

This PR may seem a bit extreme, but rather no trading interface than something with potentially unexpected behavior.

We would then include the trading interfacce again in 0.11.1 once you guys have tested the changes I'm making.

Thoughts?

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented May 17, 2016

Thoughts?

I'm very fine with it, though my concern would be that this could be considered as something that prevents users from upgrading. Then again, we don't have MetaDEx users, so it's probably not relevant.

@dexX7 dexX7 modified the milestone: 0.0.10.1 May 21, 2016

@dexX7 dexX7 merged commit fe12704 into OmniLayer:omnicore-0.0.10 May 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dexX7 added a commit that referenced this pull request May 21, 2016

Merge pull request #375
fe12704 Disable the trading UI (zathras-crypto)
@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented May 21, 2016

Tested, looks good to me. :)

@zathras-crypto zathras-crypto deleted the zathras-crypto:0.0.11-Z-DisableTradingUI branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.