Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for "bytes per sigops" limit #396

Merged

Conversation

Projects
None yet
2 participants
@dexX7
Copy link
Member

dexX7 commented Jul 6, 2016

This submission adds a workaround to get around the "bytes per sigops" limit, which makes some Class B transactions non-standard.

To get around the limit, transactions are bloated by adding additional inputs, if there are any. If no additional inputs are available, the transaction is sent nevertheless. In this case it may take a very long time to confirm.

This submission also renames the ClassAgnosticWalletTXBuilder to WalletTxBulider, because the long name seems inconvenient. :)

@dexX7 dexX7 added this to the 0.0.11.0 milestone Jul 6, 2016

dexX7 added some commits Jul 7, 2016

@dexX7

This comment has been minimized.

Copy link
Member Author

dexX7 commented Jul 7, 2016

@zathras-crypto: you may take a look at this.

I modified SelectCoins to allow specifying the minimum number of outputs to select. It's not enforced, but neither is the amount to select. The transaction generation code was adjusted to also support specifying a number of inputs to use, and in case we hit the sigops limit, then a new transaction is created with one more input. If no more inputs are available, then the transaction is sent nevertheless.

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jul 10, 2016

Reviewed & did some testing, looks good - OK to merge :)

@dexX7

This comment has been minimized.

Copy link
Member Author

dexX7 commented Jul 10, 2016

Awesome, thanks! It's a bit late, and I'm going to merge this and the other outstanding PRs tomorrow, and also tag rc2. :)

@dexX7 dexX7 merged commit 0b21dad into OmniLayer:omnicore-0.0.10 Jul 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dexX7 added a commit that referenced this pull request Jul 11, 2016

Merge pull request #396
0b21dad Rename ClassAgnosticWalletTXBuilder to WalletTxBuilder (dexX7)
230963b Try to bloat transaction to get around bytespersigops limit (dexX7)
1066be6 Add option to select specific number of outputs (dexX7)
e93e0fb Add stub for sigops workaround to wallet (dexX7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.