Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Bump version to Omni Core 0.0.11-rel #404
Very, very good point! I pushed a fix for this via e0c3156a1ce36c1e72cc4d3135a7c0916bd235bf, which increments the "build" part of our version number. This part is not included in the version string (e.g. 0.0.11.0), and should not be included in the file names either.
Given that our version scheme is a bit messed up, it would be awesome, if you could confirm that we can get away with this.
I'll prep a test to double check :)
Also completely unrelated, but which field were you using to search on 'Chest that isn't trimming properly? Is it the search bar at the top or one of the actual search pages?
Thanks for this! I didn't really understand until I actually tried it lol. That input is trimmed already which is why I didn't see the problem. So what happens is the value supplied in that field is evaluated for its length, and then that length is used to take a best guess at whether to lookup a property ID, TXID or address. The problem was that the trimming was being done after the length was evaluated, so for example an address with whitespace had a length >35, which 'Chest thinks is too long to be an address.
Easy fix, the input is now trimmed (and sanitized for special characters) before evaluating the length and it seems to be working properly now.
On the topic of 'Chest, hopefully it should feel a little faster now with some new changes I've made to way tables are indexed to lower API resource consumption.
Yep, tested & seems fine. OK to merge.
Activating with a min client version of 1100001 against a build that includes this PR works fine:
As desired the same activation with the same min client version fails on RC2: