Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow feature deactivation #429

Merged

Conversation

@zathras-crypto
Copy link

zathras-crypto commented Nov 12, 2016

This PR provides for feature deactivation in the event of an exploit being discovered.

Note: it is not possible to use this to block the transfer of tokens, users will always be able to send.

On mobile so will add a fuller description soon.

@dexX7 dexX7 added the consensus label Nov 13, 2016
@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Nov 13, 2016

First of all: wow, this is huge! Thanks for creating a PR this fast!

I'm wondering how this fits together, if we follow through with #416 and hardcode feature activations, if they already activated.

@dexX7 dexX7 added this to the 0.0.11.2 milestone Nov 14, 2016
@zathras-crypto

This comment has been minimized.

Copy link
Author

zathras-crypto commented Nov 15, 2016

Made the changes we discussed mate (added fee cache to the disable test and updated the readability for the property ID).

@dexX7 dexX7 merged commit 42579d5 into OmniLayer:omnicore-0.0.10 Nov 15, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
dexX7 added a commit that referenced this pull request Nov 15, 2016
42579d5 Change 2 to OMNI_PROPERTY_TMSC to improve code readability (thanks dexx7) (zathras-crypto)
c1b65b3 Update test to check disabling the fee cache also (zathras-crypto)
d605a1e Improve the basic tests to cover MetaDEx refunds too (zathras-crypto)
e92cf25 Add refund of all orders on the MetaDEx if it's deactivated (zathras-crypto)
21ef723 Add basic deactivation tests (zathras-crypto)
0ccc5a5 Update comments to note where DeactivateFeature lives (zathras-crypto)
ded344c Add omni_senddeactivation to RPC (zathras-crypto)
0a1dd65 Add interpret_Deactivation() and logicMath_Deactivation() (zathras-crypto)
afbedee Add DeactivateFeature function (zathras-crypto)
9383ab1 Add deactivation transaction type to omnicore.h (zathras-crypto)
2df52d2 Add payload creation for deactivating features (zathras-crypto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.