New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to Omni Core 0.0.12.0-rel #455

Merged
merged 2 commits into from Mar 13, 2017

Conversation

Projects
None yet
2 participants
@dexX7
Copy link
Member

dexX7 commented Jan 27, 2017

This bumps the version to 0.0.12.0 and prepares the release notes.

@dexX7 dexX7 added this to the 0.0.11.3 milestone Jan 27, 2017

@dexX7 dexX7 force-pushed the dexX7:oc-11.3-version branch 2 times, most recently Feb 8, 2017

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Feb 14, 2017

@zathras-crypto: what do you think about the release notes? Please let me know, if there is anything to change, or add. :) Feel free to type as you like..

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Mar 12, 2017

Hey bud, this all looks good to me - though I'm not sure we're making it clear enough that this is a mandatory upgrade. For example:

This version is built on top of v0.0.11, which is a major release and consensus critical in terms of the Omni Layer protocol rules. An upgrade is mandatory, and highly recommended. Prior releases will not be compatible with new behavior in this release.

I read that as 0.0.11 is the major release and required upgrade, which may give the impression that this isn't mandatory. Since activation will specify 0.0.11.3 as a min client version for fees & cross-prop STO, clients that haven't been upgraded will stop working.

TL:DR; I think we should be a bit clearer that this version is required once we start activating things :)

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Mar 12, 2017

Maybe we should call it 0.0.12, to have at least some consistency, in terms of bumping the version number for consensus critical stuff?

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Mar 12, 2017

Sounds perfect, I don't think we have to worry about version confusion with Bitcoin Core now - 0.0.12 would be fine :)

Bump version to Omni Core 0.0.12.0-rel
This bumps the version to 0.0.12.0 and prepares the release notes.

@dexX7 dexX7 force-pushed the dexX7:oc-11.3-version branch Mar 13, 2017

@dexX7 dexX7 changed the title Bump version to Omni Core 0.0.11.3-rel Bump version to Omni Core 0.0.12.0-rel Mar 13, 2017

@dexX7 dexX7 force-pushed the dexX7:oc-11.3-version branch to d070209 Mar 13, 2017

@dexX7 dexX7 merged commit d070209 into OmniLayer:master Mar 13, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

dexX7 added a commit that referenced this pull request Mar 13, 2017

Merge pull request #455
d070209 Update release notes for 0.0.12.0 (dexX7)
4ea9cb5 Bump version to Omni Core 0.0.12.0-rel (dexX7)
@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment