New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of bugs in the QT UI #471

Merged
merged 9 commits into from May 26, 2017

Conversation

Projects
None yet
2 participants
@zathras-crypto
Copy link

zathras-crypto commented May 25, 2017

This PR resolves a number of issues present in the QT UI following the initial work to port the UI to 0.13.x.

Further, the trading interface is considered incomplete and following discussion with @dexX7 it was agreed that the trading UI would be disabled and hidden in this version in order to move forward with release in a timely fashion.

Thanks
Z

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented May 25, 2017

Very nice, thanks @zathras-crypto!

Is this ready to go, and was this the last blocker for 0.2, besides bumping the version and adding release notes?

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented May 26, 2017

Is this ready to go

The fixes should all be safe to merge yep :)

was this the last blocker for 0.2

I ran through some sends myself on regtest and I think I caught the main & obvious UI problems I could see.

I've also been running the daemon up at OE for months now and it's solid as a rock when hit with lots of data retrieval RPCs sequentially.

We do still have that locking issue with the inputs cache and parallel requests though as experienced by the Jaxx guys - do you think we should try and ship a fix with 0.2?

I can't speak to transaction creation RPCs as OE doesn't use them, but if @achamely has been happily using it up at OmniWallet for a while then I believe we're good on that side too.

@dexX7 dexX7 added this to the Next release milestone May 26, 2017

@dexX7 dexX7 merged commit 897aa7e into OmniLayer:develop May 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dexX7 added a commit that referenced this pull request May 26, 2017

Merge #471: Fix a number of bugs in the QT UI
897aa7e Fix for missing confirmation icons in transaction history (zathrasc)
8a286cd Fix for missing splash images in makefile (zathrasc)
154e7cc Fix the missing hourglass icon on pending notifications (zathrasc)
3302f0a Fix for invisible pending notification (zathrasc)
a71d949 Remove the forced display of Omni #1 in the overview if no Omni tokens are in the wallet (zathrasc)
be5b4c8 Add Omni components to the clientmodel (zathrasc)
d121954 Use platformStyle to color the Send page icons & also to hide the icons on OSX (zathrasc)
05c16fd Hide the Exchange toolbutton and disable the signals (zathrasc)
211de8c Disable the Exchange tab (zathrasc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment