New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock fetching and processing inputs while parsing #472

Merged
merged 1 commit into from Jun 3, 2017

Conversation

Projects
None yet
2 participants
@dexX7
Copy link
Member

dexX7 commented May 27, 2017

When parsing, the access on the input cache is locked the as long as necessary, to avoid fetching inputs, and clearing the cache during one call.

@dexX7 dexX7 added this to the Next release milestone May 27, 2017

@dexX7 dexX7 force-pushed the dexX7:0.2-parse-lock branch 2 times, most recently from 1532d77 to 346b99a Jun 3, 2017

@dexX7 dexX7 force-pushed the dexX7:0.2-parse-lock branch from 346b99a to 48e7c19 Jun 3, 2017

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jun 3, 2017

Reviewed & tested all good :)

There is also no performance hit...

I did a first parse and discarded the results (to take system caching out of the equation etc)
Unpatched = 27m 33s
Patched = 27m 18s

Given your success with triggering the omni_gettransaction assert & the same test not causing the issue when this patch is included, I think we are all good to go...

OK to merge, thanks again dude :)

@dexX7 dexX7 added consensus and removed performance labels Jun 3, 2017

@dexX7 dexX7 merged commit 48e7c19 into OmniLayer:develop Jun 3, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

dexX7 added a commit that referenced this pull request Jun 3, 2017

Merge #472: Lock fetching and processing inputs while parsing
48e7c19 Lock fetching and processing inputs while parsing (dexX7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment