New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alert Keys #483

Merged
merged 4 commits into from Jul 4, 2017

Conversation

Projects
None yet
2 participants
@zathras-crypto
Copy link

zathras-crypto commented Jul 3, 2017

This PR updates the alert keys to match the keys used for activation, and also removes explicit testnet keys.

Further two changes have been included as follows:

  • Michael is no longer a regular contributor to the project - his key has been removed.
  • Adam is a project maintainer and is a signatory to activations - his key as been added.

This change should only be included with a consensus breaking release.

zathras-crypto added some commits Jul 3, 2017

Replace alert keys for mainnet with activation keys.
Note: seperate alert keys have been removed and replaced with the keys used to sign activations.

Note: Michael is no longer a regular contributor to the project, and as such his key has been removed.

Note: Adam is a project maintainer and is a signatory to activations, and as such his key as been added.

@dexX7 dexX7 added this to the Next release milestone Jul 3, 2017

@dexX7

This comment has been minimized.

Copy link
Member

dexX7 commented Jul 3, 2017

Thanks for providing this!

The alert tests need to be updated:

../../src/omnicore/test/alert_tests.cpp(59): error: in "omnicore_alert_tests/alert_manual_sources": check CheckAlertAuthorization("1zAtHRASgdHvZDfHs6xJquMghga4eG7gy") has failed
../../src/omnicore/test/alert_tests.cpp(26): error: in "omnicore_alert_tests/alert_positive_authorization": check CheckAlertAuthorization("16Zwbujf1h3v1DotKcn9XXt1m7FZn2o4mj") has failed
../../src/omnicore/test/alert_tests.cpp(27): error: in "omnicore_alert_tests/alert_positive_authorization": check CheckAlertAuthorization("1MicH2Vu4YVSvREvxW1zAx2XKo2GQomeXY") has failed
../../src/omnicore/test/alert_tests.cpp(28): error: in "omnicore_alert_tests/alert_positive_authorization": check CheckAlertAuthorization("1zAtHRASgdHvZDfHs6xJquMghga4eG7gy") has failed
../../src/omnicore/test/alert_tests.cpp(29): error: in "omnicore_alert_tests/alert_positive_authorization": check CheckAlertAuthorization("1dexX7zmPen1yBz2H9ZF62AK5TGGqGTZH") has failed
../../src/omnicore/test/alert_tests.cpp(30): error: in "omnicore_alert_tests/alert_positive_authorization": check CheckAlertAuthorization("1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P") has failed
../../src/omnicore/test/alert_tests.cpp(33): error: in "omnicore_alert_tests/alert_positive_authorization": check CheckAlertAuthorization("mpDex4kSX4iscrmiEQ8fBiPoyeTH55z23j") has failed
../../src/omnicore/test/alert_tests.cpp(34): error: in "omnicore_alert_tests/alert_positive_authorization": check CheckAlertAuthorization("mpZATHupfCLqet5N1YL48ByCM1ZBfddbGJ") has failed
../../src/omnicore/test/alert_tests.cpp(35): error: in "omnicore_alert_tests/alert_positive_authorization": check CheckAlertAuthorization("mk5SSx4kdexENHzLxk9FLhQdbbBexHUFTW") has failed

I'd change the keys, and remove the now no longer needed tests. :)

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jul 3, 2017

Ahh good catch, thanks dude!

Not quite sure how I missed that hehe, was working in exactly that point today on the Litecoin stuff! zathras-crypto@9437196

Will fix up now...

zathras-crypto added some commits Jul 3, 2017

Remove commented tests
Note, alert payloads are tested in create_payload_tests
@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Jul 3, 2017

Updated.

@dexX7 dexX7 merged commit 2cad517 into OmniLayer:develop Jul 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dexX7 added a commit that referenced this pull request Jul 4, 2017

Merge #483: Update Alert Keys
2cad517 Update the alert tests to reflect key changes (thanks @dexX7!) (zathrasc)
4a9f714 Remove commented tests (zathrasc)
98819fd Remove explicit testnet alert keys, use -omnialertallowsender for testing (zathrasc)
961853b Replace alert keys for mainnet with activation keys. (zathrasc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment