New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log spam from unconfirmed transactions #505

Merged
merged 2 commits into from Nov 23, 2017

Conversation

Projects
None yet
2 participants
@zathras-crypto

zathras-crypto commented Nov 13, 2017

Each time certain unconfirmed transactions are queried via RPC spam entries are written to the log:

This PR removes the attempt to load data for unconfirmed transactions that is not available until after processing.

Unconfirmed Send All:
TXLISTDB Error: Transaction parsed as send all but could not locate sub sends in txlistdb.

This is because transactions are only processed once included in a block and so while it's unconfirmed the sub sends have not been determined or written to leveldb.

Unconfirmed Property Creations:
findSPByTX(): ERROR: failed to find property created with {txid}

This is because the SP database does not contain any property entries that are tagged with that creation txid until that transaction has been included in a block and gets processed.

@zathras-crypto zathras-crypto changed the title from Fix log spam from unconfirmed Send All transactions to Fix log spam from unconfirmed transactions Nov 13, 2017

@dexX7 dexX7 added this to the Next release milestone Nov 14, 2017

@dexX7

This comment has been minimized.

Show comment
Hide comment
@dexX7

dexX7 Nov 14, 2017

Member

Looks good!

Member

dexX7 commented Nov 14, 2017

Looks good!

@dexX7 dexX7 merged commit 50874a4 into OmniLayer:develop Nov 23, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

dexX7 added a commit that referenced this pull request Nov 23, 2017

Merge #505: Fix log spam from unconfirmed transactions
50874a4 Fix "failed to find property creatd by {txid}" log spam from unconfirmed property creations (Zathras)
8fb15da Fix "could not locate sub sends in txlistdb" log spam from unconfirmed Send All txs (Zathras)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment