Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Mastercoin clarifications #34

Merged
merged 3 commits into from Jan 14, 2014

Conversation

Projects
None yet
4 participants
@maran
Copy link
Contributor

commented Jan 11, 2014

Some quick notes on how and when to calculate the Exodus amount and make sure all implementations use the same calculations when dealing with years.

@zathras-crypto

This comment has been minimized.

Copy link

commented on 143bb8f Jan 11, 2014

Supported.

@ripper234

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2014

LGTM

Although can you clarify what does "use the block timestamp for y" mean?

@maran

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2014

It means when you calculate the Development Mastercoins at any moment (perhaps when a transactions from Exodus gets sent) you should use the last block found timestamp.

Does that explain it?

@ripper234

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2014

Yes.

Grammar mistake - "When a transactions from Exodus"

@DavidJohnstonCEO

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2014

Makes sense to me.

@maran

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2014

@ripper234 I've been glaring over the commits for 5 minutes but I can't seem to spot that sentence, where is it exactly?

@ripper234

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2014

Ah sorry, it's just in the comments on this pull request, it's not on the commits themselves :)

You can merge this.

maran added a commit that referenced this pull request Jan 14, 2014

Merge pull request #34 from maran/ExodusNotes
Dev Mastercoin clarifications

@maran maran merged commit bfba3bd into OmniLayer:master Jan 14, 2014

@maran maran deleted the maran:ExodusNotes branch Jan 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.