test: detect circular formulas #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This test has been implemented directly in main. The test verifies that circular formula references are properly detected by the FormulaEvaluator and marked with error messages in the JSON export. The existing circular reference detection was already working correctly - this test ensures it stays that way. Great addition to test coverage! |
alpha912
added a commit
that referenced
this pull request
Oct 16, 2025
- Add CIRCULAR_FORMULA_OSF test fixture - Add test to verify circular reference detection in JSON export - Test ensures FormulaEvaluator marks circular refs with error messages - Confirms existing circular reference detection works correctly Implements test from PR #53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FormulaEvaluatorTesting
pnpm testhttps://chatgpt.com/codex/tasks/task_e_6895adbb5274832b9aa297edadb6784e