Added attribute span property for fileMemberElement #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Omnisharp-vscode side : dotnet/vscode-csharp#1938 |
rchande
suggested changes
Jan 2, 2018
| @@ -9,6 +9,10 @@ public class FileMemberElement : IComparable<FileMemberElement> | |||
|
|
|||
| public QuickFix Location { get; set; } | |||
|
|
|||
| public int AttributeSpanStart { get; set; } | |||
There was a problem hiding this comment.
Can we make these some kind of range or span type?
There was a problem hiding this comment.
@rchande We could pass both AttributeSpanStart and AttributeSpanEnd in a Span type class. But in that case we will also have to define this class in protocol.ts in omnisharp-vscode. Should that be done ?
There was a problem hiding this comment.
Protocol.ts defines a range type: https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/omnisharp/protocol.ts#L450
There was a problem hiding this comment.
@rchande Yes it does, but the range has the start and end as Point type. And I couldn't spot a function in omnisharp-roslyn that converts from a span to range
rchande
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : dotnet/vscode-csharp#429
Added properties to contain the attribute span in a file member element, which will be used by the editor to display the "# of references" before the attributes.