Changes for empty reponse for GoToDefinition on PropertyAccessorSymbol #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
reviewed
Jan 12, 2018
| @@ -47,6 +47,8 @@ public GotoDefinitionService(OmniSharpWorkspace workspace, MetadataHelper metada | |||
| // go to definition for namespaces is not supported | |||
| if (symbol != null && !(symbol is INamespaceSymbol)) | |||
| { | |||
| if (symbol is IMethodSymbol methodSymbol && methodSymbol.AssociatedSymbol is IPropertySymbol) | |||
There was a problem hiding this comment.
there is already the same is IMethodSymbol 2 lines lower so you may want to roll them up together and just check for IPropertySymbol there
rchande
reviewed
Jan 12, 2018
| @@ -31,6 +31,110 @@ class {|def:Foo|} { | |||
| await TestGoToSourceAsync(testFile); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task DoesnotReturnOnPropertAccessorGet() | |||
rchande
approved these changes
Jan 12, 2018
| @@ -47,6 +47,8 @@ public GotoDefinitionService(OmniSharpWorkspace workspace, MetadataHelper metada | |||
| // go to definition for namespaces is not supported | |||
| if (symbol != null && !(symbol is INamespaceSymbol)) | |||
| { | |||
| if (symbol is IMethodSymbol methodSymbol && methodSymbol.AssociatedSymbol is IPropertySymbol) | |||
filipw
approved these changes
Jan 29, 2018
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/vscode-csharp#1949
Changes:
Please review : @DustinCampbell @TheRealPiotrP @rchande