Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly use cancellation token in Metadata service #1631

Merged
merged 2 commits into from Oct 12, 2019

Conversation

@filipw
Copy link
Member

filipw commented Oct 11, 2019

GetAndAddDocumentFromMetadata doesn't respect the passed-in cancellation token.

@filipw filipw requested review from david-driscoll, rchande and mholo65 Oct 11, 2019
Copy link
Member

mholo65 left a comment

Nice catch!

@david-driscoll david-driscoll merged commit 538a732 into OmniSharp:master Oct 12, 2019
6 checks passed
6 checks passed
OmniSharp.omnisharp-roslyn Build #1.34.6-PullRequest1631.17 succeeded
Details
OmniSharp.omnisharp-roslyn (GitVersion) GitVersion succeeded
Details
OmniSharp.omnisharp-roslyn (Linux) Linux succeeded
Details
OmniSharp.omnisharp-roslyn (Release) Release succeeded
Details
OmniSharp.omnisharp-roslyn (Windows) Windows succeeded
Details
OmniSharp.omnisharp-roslyn (macOS) macOS succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.