Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to Roslyn 3.4.0-beta3-19516-01 #1634

Merged
merged 4 commits into from Oct 18, 2019

Conversation

@filipw
Copy link
Member

filipw commented Oct 16, 2019

We have fallen behind the schedule a bit (especially with .NET Core 3.1 Preview 1 out already). We had consumed 3.4.0-beta1-19460-02 over a month ago but even Nuget publicly has a newer version now.

This PR pulls in the latest build intended for VS 16.4.

Copy link
Collaborator

JoeRobich left a comment

LGTM

filipw added 4 commits Oct 16, 2019
@filipw filipw force-pushed the feature/roslyn-update branch from cc8cdc3 to 8461fa2 Oct 17, 2019
@filipw

This comment has been minimized.

Copy link
Member Author

filipw commented Oct 17, 2019

This also fixes #1619. I added a negative test so that we don't regress on a closed bug.

@filipw

This comment has been minimized.

Copy link
Member Author

filipw commented Oct 17, 2019

@david-driscoll are you ok with merging this?

@david-driscoll

This comment has been minimized.

Copy link
Member

david-driscoll commented Oct 18, 2019

@filipw filipw merged commit 8df045a into master Oct 18, 2019
6 checks passed
6 checks passed
OmniSharp.omnisharp-roslyn Build #1.34.6-PullRequest1634.34 succeeded
Details
OmniSharp.omnisharp-roslyn (GitVersion) GitVersion succeeded
Details
OmniSharp.omnisharp-roslyn (Linux) Linux succeeded
Details
OmniSharp.omnisharp-roslyn (Release) Release succeeded
Details
OmniSharp.omnisharp-roslyn (Windows) Windows succeeded
Details
OmniSharp.omnisharp-roslyn (macOS) macOS succeeded
Details
@filipw filipw deleted the feature/roslyn-update branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.